Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314833003: Shared commandline flags. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -109 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 4 chunks +35 lines, -33 lines 0 comments Download
A pkg/compiler/lib/src/commandline_options.dart View 1 1 chunk +48 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 6 chunks +44 lines, -43 lines 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/bad_loop_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/duplicate_library_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/frontend_checker.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/in_user_code_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/show_package_warnings_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/space_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/warnings_checker.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 3 months ago (2015-09-09 13:35:33 UTC) #2
sigurdm
LGTM! https://codereview.chromium.org/1314833003/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/1314833003/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode318 pkg/compiler/lib/src/dart2js.dart:318: new OptionHandler('--version', (_) => wantVersion = true), Missing ...
5 years, 3 months ago (2015-09-09 13:40:31 UTC) #3
Johnni Winther
https://codereview.chromium.org/1314833003/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/1314833003/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode318 pkg/compiler/lib/src/dart2js.dart:318: new OptionHandler('--version', (_) => wantVersion = true), On 2015/09/09 ...
5 years, 3 months ago (2015-09-09 13:50:54 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-09 13:53:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
234f09fa7e67a627531eca0effaa6696eb1cf6de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698