Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tests/compiler/dart2js/analyze_only_test.dart

Issue 1314833003: Shared commandline flags. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/analyze_helper.dart ('k') | tests/compiler/dart2js/bad_loop_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/analyze_only_test.dart
diff --git a/tests/compiler/dart2js/analyze_only_test.dart b/tests/compiler/dart2js/analyze_only_test.dart
index bb42728caf564e08e0ec3b9768cac15927518113..08100a62d3978ba6a09fd660c611730c536e1039 100644
--- a/tests/compiler/dart2js/analyze_only_test.dart
+++ b/tests/compiler/dart2js/analyze_only_test.dart
@@ -11,7 +11,7 @@ import "package:async_helper/async_helper.dart";
import '../../utils/dummy_compiler_test.dart' as dummy;
import 'package:compiler/compiler.dart';
-
+import 'package:compiler/src/commandline_options.dart';
import 'package:compiler/src/diagnostics/messages.dart' show
MessageKind, MessageTemplate;
@@ -64,7 +64,7 @@ runCompiler(String main, List<String> options,
main() {
runCompiler(
"",
- ['--generate-code-with-compile-time-errors'],
+ [Flags.generateCodeWithCompileTimeErrors],
(String code, List errors, List warnings) {
Expect.isNotNull(code);
Expect.isTrue(errors.isEmpty, 'errors is not empty: $errors');
@@ -77,7 +77,7 @@ main() {
runCompiler(
"main() {}",
- ['--generate-code-with-compile-time-errors'],
+ [Flags.generateCodeWithCompileTimeErrors],
(String code, List errors, List warnings) {
Expect.isNotNull(code);
Expect.isTrue(errors.isEmpty);
@@ -86,7 +86,7 @@ main() {
runCompiler(
"",
- ['--analyze-only'],
+ [Flags.analyzeOnly],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty, 'errors is not empty: $errors');
@@ -99,7 +99,7 @@ main() {
runCompiler(
"main() {}",
- ['--analyze-only'],
+ [Flags.analyzeOnly],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty);
@@ -108,7 +108,7 @@ main() {
runCompiler(
"Foo foo; // Unresolved but not analyzed.",
- ['--analyze-only'],
+ [Flags.analyzeOnly],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty, 'errors is not empty: $errors');
@@ -123,7 +123,7 @@ main() {
"""main() {
Foo foo; // Unresolved and analyzed.
}""",
- ['--analyze-only'],
+ [Flags.analyzeOnly],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty);
@@ -136,7 +136,7 @@ main() {
"""main() {
Foo foo; // Unresolved and analyzed.
}""",
- ['--analyze-only', '--analyze-signatures-only'],
+ [Flags.analyzeOnly, Flags.analyzeSignaturesOnly],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty);
@@ -145,7 +145,7 @@ main() {
runCompiler(
"Foo foo; // Unresolved and analyzed.",
- ['--analyze-only', '--analyze-all'],
+ [Flags.analyzeOnly, Flags.analyzeAll],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty);
@@ -156,7 +156,7 @@ main() {
runCompiler(
"""Foo foo; // Unresolved and analyzed.
main() {}""",
- ['--analyze-only', '--analyze-all'],
+ [Flags.analyzeOnly, Flags.analyzeAll],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty, 'Unexpected errors: $errors.');
@@ -167,7 +167,7 @@ main() {
runCompiler(
"",
- ['--analyze-only', '--analyze-all'],
+ [Flags.analyzeOnly, Flags.analyzeAll],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty);
@@ -177,7 +177,7 @@ main() {
// --analyze-signatures-only implies --analyze-only
runCompiler(
"",
- ['--analyze-signatures-only', '--analyze-all'],
+ [Flags.analyzeSignaturesOnly, Flags.analyzeAll],
(String code, List errors, List warnings) {
Expect.isNull(code);
Expect.isTrue(errors.isEmpty);
« no previous file with comments | « tests/compiler/dart2js/analyze_helper.dart ('k') | tests/compiler/dart2js/bad_loop_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698