Add a library for manipulating stack traces.

Add a library for manipulating stack traces.

Committed: https://code.google.com/p/dart/source/detail?r=20582

[Bob Nystrom, 2013-03-27 00:46:44]

Very nice. Some suggestions then LGTM.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:13: final _regExp = new
RegExp(r'^#\d+\s+([^\s].*) \((.+):(\d+):(\d+)\)$');
Better name.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:63: throw new ArgumentError("Argument [level]
must be greater than or equal to "
Long line.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:72: /// [frame] should be formatted in the
same was a native stack trace frame.
was -> way as

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:87: newFrames.add(frame);
Given that you are imperatively building up a result list here, using reduce()
seems a bit perverse. How about just using a for loop?

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:89: var library =
frame.library.replaceAll(new RegExp(r"-patch$"), '');
Hoist this regex out to a top level final variable?

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:113: String _padRight(String string, int
length) {
Make a top-level function? It doesn't access any instance state.

[nweiz, 2013-03-27 21:15:46]

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:13: final _regExp = new
RegExp(r'^#\d+\s+([^\s].*) \((.+):(\d+):(\d+)\)$');
On 2013/03/27 00:46:44, Bob Nystrom wrote:
> Better name.

Done.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:63: throw new ArgumentError("Argument [level]
must be greater than or equal to "
On 2013/03/27 00:46:44, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:72: /// [frame] should be formatted in the
same was a native stack trace frame.
On 2013/03/27 00:46:44, Bob Nystrom wrote:
> was -> way as

Done.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:87: newFrames.add(frame);
On 2013/03/27 00:46:44, Bob Nystrom wrote:
> Given that you are imperatively building up a result list here, using reduce()
> seems a bit perverse. How about just using a for loop?

Done.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:89: var library =
frame.library.replaceAll(new RegExp(r"-patch$"), '');
On 2013/03/27 00:46:44, Bob Nystrom wrote:
> Hoist this regex out to a top level final variable?

I really hate that we have to do this for every regular expression that we use,
but done.

https://codereview.chromium.org/13102003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:113: String _padRight(String string, int
length) {
On 2013/03/27 00:46:44, Bob Nystrom wrote:
> Make a top-level function? It doesn't access any instance state.

Done.

[nweiz, 2013-03-27 21:16:03]

Committed patchset #2 manually as r20582 (presubmit successful).