Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1307663007: Rename NavigationHolder to NavigationCollector. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M pkg/analysis_server/lib/analysis/navigation/navigation_core.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 4 chunks +10 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-09 20:08:19 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-09 20:27:06 UTC) #2
scheglov
5 years, 3 months ago (2015-09-09 20:27:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d13a9ec66633ec9c618a9160d9a89f1c5c1d3fdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698