Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306723008: pkg/http: Removed uses of Chain.track (Closed)

Created:
5 years, 3 months ago by kevmoo
Modified:
5 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/http.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Patch Set 3 : sdk version oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -34 lines) Patch
M CHANGELOG.md View 1 1 chunk +6 lines, -0 lines 0 comments Download
M lib/src/base_client.dart View 1 2 chunks +18 lines, -20 lines 0 comments Download
M lib/src/io_client.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M lib/src/multipart_file.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M lib/src/utils.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 3 months ago (2015-08-25 22:55:05 UTC) #2
nweiz
https://codereview.chromium.org/1306723008/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1306723008/diff/1/CHANGELOG.md#newcode1 CHANGELOG.md:1: ## 0.11.4 This should be 0.11.3+1. https://codereview.chromium.org/1306723008/diff/1/lib/src/base_client.dart File lib/src/base_client.dart ...
5 years, 3 months ago (2015-08-25 23:25:00 UTC) #3
kevmoo
PTAL https://codereview.chromium.org/1306723008/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1306723008/diff/1/CHANGELOG.md#newcode1 CHANGELOG.md:1: ## 0.11.4 On 2015/08/25 23:25:00, nweiz wrote: > ...
5 years, 3 months ago (2015-08-27 21:14:20 UTC) #4
nweiz
lgtm
5 years, 3 months ago (2015-08-28 00:37:17 UTC) #5
kevmoo
5 years, 3 months ago (2015-08-28 01:08:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
8ecdfac7efb66f3297a60e96069336361fcf99bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698