pkg/http: Removed uses of Chain.track

lib/src/base_client.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library base_client;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:typed_data';
 
 import 'base_request.dart';
 import 'client.dart';
 import 'exception.dart';
 import 'request.dart';
 import 'response.dart';
 import 'streamed_response.dart';
-import 'utils.dart';
 
 /// The abstract base class for an HTTP client. This is a mixin-style class;
 /// subclasses only need to implement [send] and maybe [close], and then they
 /// get various convenience methods for free.
 abstract class BaseClient implements Client {
   /// Sends an HTTP HEAD request with the given headers to the given URL, which
   /// can be a [Uri] or a [String].
   ///
   /// For more fine-grained control over the request, use [send] instead.
   Future<Response> head(url, {Map<String, String> headers}) =>
@@ skipping 116 matching lines @@
   /// Implementers should call [BaseRequest.finalize] to get the body of the
   /// request as a [ByteStream]. They shouldn't make any assumptions about the
   /// state of the stream; it could have data written to it asynchronously at a
   /// later point, or it could already be closed when it's returned. Any
   /// internal HTTP errors should be wrapped as [ClientException]s.
   Future<StreamedResponse> send(BaseRequest request);
 
   /// Sends a non-streaming [Request] and returns a non-streaming [Response].
   Future<Response> _sendUnstreamed(String method, url,
       Map<String, String> headers, [body, Encoding encoding]) {
-    return syncFuture(() {

[nweiz, 2015/08/25 23:25:00]

If you're going to remove this, make the function async instead.

[kevmoo, 2015/08/27 21:14:20]

Done - updated min SDK to 1.9

-      if (url is String) url = Uri.parse(url);
-      var request = new Request(method, url);
 
-      if (headers != null) request.headers.addAll(headers);
-      if (encoding != null) request.encoding = encoding;
-      if (body != null) {
-        if (body is String) {
-          request.body = body;
-        } else if (body is List) {
-          request.bodyBytes = body;
-        } else if (body is Map) {
-          request.bodyFields = body;
-        } else {
-          throw new ArgumentError('Invalid request body "$body".');
-        }
+    if (url is String) url = Uri.parse(url);
+    var request = new Request(method, url);
+
+    if (headers != null) request.headers.addAll(headers);
+    if (encoding != null) request.encoding = encoding;
+    if (body != null) {
+      if (body is String) {
+        request.body = body;
+      } else if (body is List) {
+        request.bodyBytes = body;
+      } else if (body is Map) {
+        request.bodyFields = body;
+      } else {
+        throw new ArgumentError('Invalid request body "$body".');
       }
+    }
 
-      return send(request);
-    }).then(Response.fromStream);
+    return send(request).then(Response.fromStream);
   }
 
   /// Throws an error if [response] is not successful.
   void _checkResponseSuccess(url, Response response) {
     if (response.statusCode < 400) return;
     var message = "Request to $url failed with status ${response.statusCode}";
     if (response.reasonPhrase != null) {
       message = "$message: ${response.reasonPhrase}";
     }
     if (url is String) url = Uri.parse(url);
     throw new ClientException("$message.", url);
   }
 
   /// Closes the client and cleans up any resources associated with it. It's
   /// important to close each client when it's done being used; failing to do so
   /// can cause the Dart process to hang.
   void close() {}
 }