Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306143002: Remove SendResolver.computeSendStructure. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Patch Set 3 : Fix handling of invalid this access. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -573 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 9 chunks +52 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +0 lines, -535 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 3 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-21 14:00:33 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1306143002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1306143002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode795 pkg/compiler/lib/src/resolution/members.dart:795: AccessSemantics checkThisAccess(Send node) { Since this is not ...
5 years, 4 months ago (2015-08-21 15:20:52 UTC) #3
Johnni Winther
https://codereview.chromium.org/1306143002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1306143002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode795 pkg/compiler/lib/src/resolution/members.dart:795: AccessSemantics checkThisAccess(Send node) { On 2015/08/21 15:20:52, floitsch wrote: ...
5 years, 4 months ago (2015-08-24 09:00:24 UTC) #4
Johnni Winther
Committed patchset #1 (id:1) manually as 4013a9aae54ee60d344247d295b750f370ce2417 (presubmit successful).
5 years, 4 months ago (2015-08-24 09:31:38 UTC) #5
floitsch
https://codereview.chromium.org/1306143002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1306143002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode795 pkg/compiler/lib/src/resolution/members.dart:795: AccessSemantics checkThisAccess(Send node) { On 2015/08/24 09:00:24, Johnni Winther ...
5 years, 4 months ago (2015-08-24 11:46:18 UTC) #6
Johnni Winther
PTAL at the last patch
5 years, 4 months ago (2015-08-24 12:16:00 UTC) #7
floitsch
LGTM.
5 years, 4 months ago (2015-08-24 14:17:23 UTC) #8
Johnni Winther
5 years, 4 months ago (2015-08-25 07:32:36 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
4ed23aff42c2adb568af078002ea5838deb032f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698