Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: pkg/compiler/lib/src/resolution/semantic_visitor.dart

Issue 1306143002: Remove SendResolver.computeSendStructure. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix handling of invalid this access. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.semantics_visitor; 5 library dart2js.semantics_visitor;
6 6
7 import '../constants/expressions.dart'; 7 import '../constants/expressions.dart';
8 import '../dart_types.dart'; 8 import '../dart_types.dart';
9 import '../diagnostics/spannable.dart' show 9 import '../diagnostics/spannable.dart' show
10 Spannable, 10 Spannable,
(...skipping 26 matching lines...) Expand all
37 return sendVisitor.visitThisGet(node, arg); 37 return sendVisitor.visitThisGet(node, arg);
38 } 38 }
39 return null; 39 return null;
40 } 40 }
41 41
42 @override 42 @override
43 R visitSend(Send node) { 43 R visitSend(Send node) {
44 // TODO(johnniwinther): Support argument. 44 // TODO(johnniwinther): Support argument.
45 A arg = null; 45 A arg = null;
46 46
47 SendStructure structure = computeSendStructure(node); 47 SendStructure structure = elements.getSendStructure(node);
48 if (structure == null) { 48 if (structure == null) {
49 return internalError(node, 'No structure for $node'); 49 return internalError(node, 'No structure for $node');
50 } else { 50 } else {
51 return structure.dispatch(sendVisitor, node, arg); 51 return structure.dispatch(sendVisitor, node, arg);
52 } 52 }
53 } 53 }
54 54
55 @override 55 @override
56 R visitSendSet(SendSet node) { 56 R visitSendSet(SendSet node) {
57 return visitSend(node); 57 return visitSend(node);
(...skipping 5097 matching lines...) Expand 10 before | Expand all | Expand 10 after
5155 /// C() : this._(42); 5155 /// C() : this._(42);
5156 /// } 5156 /// }
5157 /// 5157 ///
5158 R errorUnresolvedThisConstructorInvoke( 5158 R errorUnresolvedThisConstructorInvoke(
5159 Send node, 5159 Send node,
5160 Element element, 5160 Element element,
5161 NodeList arguments, 5161 NodeList arguments,
5162 Selector selector, 5162 Selector selector,
5163 A arg); 5163 A arg);
5164 } 5164 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/resolution/registry.dart ('k') | pkg/compiler/lib/src/resolution/send_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698