Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1305123003: Don't call StoreBuffer::ShutDown yet (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
zra, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Keep StoreBuffer::global_mutex_ and global_empty_ alive. At Dart::CleanUp time, there may still be threads around that access their store buffer, so we need to keep these around until @zanderso lands the clean shutdown CL. We should stop leaking them once we cleanly stop all threads at VM shutdown (see issue 23844). BUG=https://github.com/dart-lang/sdk/issues/24169 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/028c9952959be3b1f275c3cfbe805ab80c49f07a

Patch Set 1 #

Patch Set 2 : Keep both. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/dart.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
koda
5 years, 4 months ago (2015-08-21 19:58:59 UTC) #2
Ivan Posva
LGTM -ip
5 years, 4 months ago (2015-08-21 20:00:08 UTC) #3
koda
Per offline discussion, kept both the mutex and list, and just moved the ShutDown call ...
5 years, 4 months ago (2015-08-21 20:08:01 UTC) #4
koda
5 years, 4 months ago (2015-08-21 20:09:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
028c9952959be3b1f275c3cfbe805ab80c49f07a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698