Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: runtime/vm/dart.cc

Issue 1305123003: Don't call StoreBuffer::ShutDown yet (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Keep both. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/cpu.h" 8 #include "vm/cpu.h"
9 #include "vm/dart_api_state.h" 9 #include "vm/dart_api_state.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 Thread::EnterIsolate(vm_isolate_); 209 Thread::EnterIsolate(vm_isolate_);
210 210
211 // There is a planned and known asymmetry here: We exit one scope for the VM 211 // There is a planned and known asymmetry here: We exit one scope for the VM
212 // isolate to account for the scope that was entered in Dart_InitOnce. 212 // isolate to account for the scope that was entered in Dart_InitOnce.
213 Dart_ExitScope(); 213 Dart_ExitScope();
214 214
215 ShutdownIsolate(); 215 ShutdownIsolate();
216 vm_isolate_ = NULL; 216 vm_isolate_ = NULL;
217 217
218 TargetCPUFeatures::Cleanup(); 218 TargetCPUFeatures::Cleanup();
219 StoreBuffer::ShutDown();
219 #endif 220 #endif
220 221
221 Profiler::Shutdown(); 222 Profiler::Shutdown();
222 CodeObservers::DeleteAll(); 223 CodeObservers::DeleteAll();
223 Timeline::Shutdown(); 224 Timeline::Shutdown();
224 StoreBuffer::ShutDown();
225 225
226 return NULL; 226 return NULL;
227 } 227 }
228 228
229 229
230 Isolate* Dart::CreateIsolate(const char* name_prefix, 230 Isolate* Dart::CreateIsolate(const char* name_prefix,
231 const Dart_IsolateFlags& api_flags) { 231 const Dart_IsolateFlags& api_flags) {
232 // Create a new isolate. 232 // Create a new isolate.
233 Isolate* isolate = Isolate::Init(name_prefix, api_flags); 233 Isolate* isolate = Isolate::Init(name_prefix, api_flags);
234 ASSERT(isolate != NULL); 234 ASSERT(isolate != NULL);
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 return predefined_handles_->handles_.IsValidScopedHandle(address); 380 return predefined_handles_->handles_.IsValidScopedHandle(address);
381 } 381 }
382 382
383 383
384 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 384 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
385 ASSERT(predefined_handles_ != NULL); 385 ASSERT(predefined_handles_ != NULL);
386 return predefined_handles_->api_handles_.IsValidHandle(handle); 386 return predefined_handles_->api_handles_.IsValidHandle(handle);
387 } 387 }
388 388
389 } // namespace dart 389 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698