Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1304743003: VM: Remove dead code from arm/mips/arm64 call instruction patterns (Closed)

Created:
5 years, 4 months ago by Florian Schneider
Modified:
5 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove dead code from arm/mips/arm64 call instruction patterns BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/2e24b091ff5598e3df495e0f2bc37f5aebe9479c

Patch Set 1 #

Patch Set 2 : addressed feedback from previous CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -72 lines) Patch
M runtime/vm/instructions_arm.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/instructions_arm.cc View 1 2 chunks +4 lines, -21 lines 0 comments Download
M runtime/vm/instructions_arm64.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/instructions_arm64.cc View 1 2 chunks +4 lines, -21 lines 0 comments Download
M runtime/vm/instructions_mips.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/instructions_mips.cc View 1 2 chunks +4 lines, -21 lines 0 comments Download
M runtime/vm/object.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 4 months ago (2015-08-20 08:47:53 UTC) #2
srdjan
lgtm
5 years, 4 months ago (2015-08-20 15:13:16 UTC) #3
Florian Schneider
5 years, 4 months ago (2015-08-21 07:44:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2e24b091ff5598e3df495e0f2bc37f5aebe9479c.

Powered by Google App Engine
This is Rietveld 408576698