Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: runtime/vm/instructions_arm.cc

Issue 1304743003: VM: Remove dead code from arm/mips/arm64 call instruction patterns (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed feedback from previous CL Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_arm.h ('k') | runtime/vm/instructions_arm64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_arm.cc
diff --git a/runtime/vm/instructions_arm.cc b/runtime/vm/instructions_arm.cc
index 6f52b56d142dda0050582c2c03f3f896e6a28837..c88b18ffc1fb154222bfa9446d2fb4353747ce1c 100644
--- a/runtime/vm/instructions_arm.cc
+++ b/runtime/vm/instructions_arm.cc
@@ -16,10 +16,8 @@ namespace dart {
CallPattern::CallPattern(uword pc, const Code& code)
: object_pool_(ObjectPool::Handle(code.GetObjectPool())),
end_(pc),
- args_desc_load_end_(0),
ic_data_load_end_(0),
target_address_pool_index_(-1),
- args_desc_(Array::Handle()),
ic_data_(ICData::Handle()) {
ASSERT(code.ContainsInstructionAt(pc));
// Last instruction: blx lr.
@@ -158,28 +156,13 @@ uword InstructionPattern::DecodeLoadWordFromPool(uword end,
RawICData* CallPattern::IcData() {
if (ic_data_.IsNull()) {
Register reg;
- args_desc_load_end_ =
- InstructionPattern::DecodeLoadObject(ic_data_load_end_,
- object_pool_,
- &reg,
- &ic_data_);
- ASSERT(reg == R5);
- }
- return ic_data_.raw();
-}
-
-
-RawArray* CallPattern::ClosureArgumentsDescriptor() {
- if (args_desc_.IsNull()) {
- IcData(); // Loading of the ic_data must be decoded first, if not already.
- Register reg;
- InstructionPattern::DecodeLoadObject(args_desc_load_end_,
+ InstructionPattern::DecodeLoadObject(ic_data_load_end_,
object_pool_,
&reg,
- &args_desc_);
- ASSERT(reg == R4);
+ &ic_data_);
+ ASSERT(reg == R5);
}
- return args_desc_.raw();
+ return ic_data_.raw();
}
« no previous file with comments | « runtime/vm/instructions_arm.h ('k') | runtime/vm/instructions_arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698