Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1303503002: Refactor updates of locals. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -47 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +52 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 6 chunks +19 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 3 chunks +6 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 6 chunks +33 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-18 14:15:33 UTC) #2
Johnni Winther
Ping
5 years, 4 months ago (2015-08-19 11:15:08 UTC) #3
floitsch
LGTM.
5 years, 4 months ago (2015-08-19 14:18:29 UTC) #4
Johnni Winther
5 years, 4 months ago (2015-08-20 10:32:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b731e6230b6b6ccd2814761c1253aa20f04c63db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698