Refactor updates of locals.

tests/compiler/dart2js/semantic_visitor_test_send_data.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor_test;
 
 const Map<String, List<Test>> SEND_TESTS = const {
   'Parameters': const [
     // Parameters
     const Test('m(o) => o;',
         const Visit(VisitKind.VISIT_PARAMETER_GET,
                     element: 'parameter(m#o)')),
     const Test('m(o) { o = 42; }',
         const Visit(VisitKind.VISIT_PARAMETER_SET,
                     element: 'parameter(m#o)',
                     rhs:'42')),
     const Test('m(o) { o(null, 42); }',
         const Visit(VisitKind.VISIT_PARAMETER_INVOKE,
                     element: 'parameter(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
-    // TODO(johnniwinther): Expect [VISIT_FINAL_PARAMETER_SET] instead.
     const Test('m(final o) { o = 42; }',
-        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_FINAL_PARAMETER_SET,
+                    element: 'parameter(m#o)',
                     rhs:'42')),
   ],
   'Local variables': const [
     // Local variables
     const Test('m() { var o; return o; }',
         const Visit(VisitKind.VISIT_LOCAL_VARIABLE_GET,
                     element: 'variable(m#o)')),
     const Test('m() { var o; o = 42; }',
         const Visit(VisitKind.VISIT_LOCAL_VARIABLE_SET,
                     element: 'variable(m#o)',
                     rhs:'42')),
     const Test('m() { var o; o(null, 42); }',
         const Visit(VisitKind.VISIT_LOCAL_VARIABLE_INVOKE,
                     element: 'variable(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
-    // TODO(johnniwinther): Expect [VISIT_FINAL_LOCAL_VARIABLE_SET] instead.
     const Test('m() { final o = 0; o = 42; }',
-        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_FINAL_LOCAL_VARIABLE_SET,
+                    element: 'variable(m#o)',
                     rhs:'42')),
-    // TODO(johnniwinther): Expect [VISIT_FINAL_LOCAL_VARIABLE_SET] instead.
     const Test('m() { const o = 0; o = 42; }',
-        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_FINAL_LOCAL_VARIABLE_SET,
+                    element: 'variable(m#o)',
                     rhs:'42')),
   ],
   'Local functions': const [
     // Local functions
     const Test('m() { o(a, b) {}; return o; }',
         const Visit(VisitKind.VISIT_LOCAL_FUNCTION_GET,
                     element: 'function(m#o)')),
     const Test('m() { o(a, b) {}; o(null, 42); }',
         const Visit(VisitKind.VISIT_LOCAL_FUNCTION_INVOKE,
                     element: 'function(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
     const Test('m() { o(a) {}; o(null, 42); }',
         const Visit(VisitKind.VISIT_LOCAL_FUNCTION_INCOMPATIBLE_INVOKE,
                     element: 'function(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
-    // TODO(johnniwinther): Expect [VISIT_LOCAL_FUNCTION_SET] instead.
     const Test('m() { o(a, b) {}; o = 42; }',
-        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_LOCAL_FUNCTION_SET,
+                    element: 'function(m#o)',
                     rhs: '42')),
   ],
   'Static fields': const [
     // Static fields
     const Test(
         '''
         class C { static var o; }
         m() => C.o;
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_GET,
@@ skipping 1330 matching lines @@
         '''
         class C {}
         m() => C(null, 42);
         ''',
         const Visit(VisitKind.VISIT_CLASS_TYPE_LITERAL_INVOKE,
                     constant: 'C',
                     arguments: '(null,42)')),
     const Test(
         '''
         class C {}
+        m() => C = 42;
+        ''',
+        const Visit(VisitKind.VISIT_CLASS_TYPE_LITERAL_SET,
+                    constant: 'C',
+                    rhs: '42')),
+    const Test(
+        '''
+        class C {}
         m() => C += 42;
         ''',
         const Visit(VisitKind.VISIT_CLASS_TYPE_LITERAL_COMPOUND,
                     constant: 'C',
                     operator: '+=',
                     rhs: '42')),
     const Test(
         '''
         class C {}
         m() => ++C;
@@ skipping 34 matching lines @@
         '''
         typedef F();
         m() => F(null, 42);
         ''',
         const Visit(VisitKind.VISIT_TYPEDEF_TYPE_LITERAL_INVOKE,
                     constant: 'F',
                     arguments: '(null,42)')),
     const Test(
         '''
         typedef F();
+        m() => F = 42;
+        ''',
+        const Visit(VisitKind.VISIT_TYPEDEF_TYPE_LITERAL_SET,
+                    constant: 'F',
+                    rhs: '42')),
+    const Test(
+        '''
+        typedef F();
         m() => F += 42;
         ''',
         const Visit(VisitKind.VISIT_TYPEDEF_TYPE_LITERAL_COMPOUND,
                     constant: 'F',
                     operator: '+=',
                     rhs: '42')),
     const Test(
         '''
         typedef F();
         m() => ++F;
@@ skipping 25 matching lines @@
         class C<T> {
           m() => T(null, 42);
         }
         ''',
         const Visit(VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_INVOKE,
                     element: 'type_variable(C#T)',
                     arguments: '(null,42)')),
     const Test.clazz(
         '''
         class C<T> {
+          m() => T = 42;
+        }
+        ''',
+        const Visit(VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_SET,
+                    element: 'type_variable(C#T)',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C<T> {
           m() => T += 42;
         }
         ''',
         const Visit(VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_COMPOUND,
                     element: 'type_variable(C#T)',
                     operator: '+=',
                     rhs: '42')),
     const Test.clazz(
         '''
         class C<T> {
@@ skipping 2395 matching lines @@
             rhs: '42')),
     const Test.prefix(
         '''
         var o;
         ''',
         'm() => p?.o;',
         const Visit(VisitKind.ERROR_INVALID_GET,
             error: MessageKind.PREFIX_AS_EXPRESSION)),
   ],
 };