Issue 1301903002: Record information about constants in dump info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1301903002: Record information about constants in dump info (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 4 months ago

Reviewers:
Johnni Winther, Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Total comments: 2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -24 lines)			Patch
M	pkg/compiler/lib/src/dump_info.dart	View	9 chunks	+41 lines, -22 lines	1 comment	Download
M	pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/compiler/pubspec.yaml	View	1 chunk	+1 line, -1 line	1 comment	Download

Total messages: 4 (1 generated)

Siggi Cherem (dart-lang)

This change requires the changes in dart2js_info sent out here: https://codereview.chromium.org/1300513005/. This was about 3% ...

5 years, 4 months ago (2015-08-19 04:21:08 UTC) #2

Siggi Cherem (dart-lang)

5 years, 4 months ago (2015-08-19 20:52:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aae02054d2895de2847fb01f0f0ff002c29d7401 (presubmit successful).