Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1301583002: Refactoring resolution of updates to type literals. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactoring resolution of updates to type literals. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/1d356f807270545fa0efc5244ab1d4e9dd064f1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -36 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 10 chunks +120 lines, -26 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 9 chunks +113 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-17 13:12:44 UTC) #2
floitsch
LGTM.
5 years, 4 months ago (2015-08-17 13:36:02 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-17 14:23:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d356f807270545fa0efc5244ab1d4e9dd064f1c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698