Refactoring resolution of updates to type literals.

tests/compiler/dart2js/semantic_visitor_test_send_data.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor_test;
 
 const Map<String, List<Test>> SEND_TESTS = const {
   'Parameters': const [
     // Parameters
     const Test('m(o) => o;',
@@ skipping 89 matching lines @@
                     element: 'field(C#o)')),
     const Test.prefix(
         '''
         class C {
           static var o;
         }
         ''',
         'm() => p.C.o;',
         const Visit(VisitKind.VISIT_STATIC_FIELD_GET,
                     element: 'field(C#o)')),
+    const Test.clazz(
+        '''
+        class C {
+          var o;
+          static m() => o;
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_GET,
+                    error: MessageKind.NO_INSTANCE_AVAILABLE)),
     const Test.prefix(
         '''
         class C {
           static var o;
         }
         ''',
         'm() => p.C.o;',
         const [
           const Visit(VisitKind.PREVISIT_DEFERRED_ACCESS,
                       element: 'prefix(p)'),
@@ skipping 62 matching lines @@
         ],
         isDeferred: true),
     const Test(
         '''
         class C {}
         m() => C.this;
         ''',
         null),
     const Test(
         '''
-        class C { static var o; }
+        class C {
+          static var o;
+        }
         m() { C.o = 42; }
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_SET,
                     element: 'field(C#o)',
                     rhs: '42')),
     const Test.clazz(
         '''
         class C {
           static var o;
           m() { o = 42; }
@@ skipping 15 matching lines @@
     const Test.prefix(
         '''
         class C {
           static var o;
         }
         ''',
         'm() { p.C.o = 42; }',
         const Visit(VisitKind.VISIT_STATIC_FIELD_SET,
                     element: 'field(C#o)',
                     rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          var o;
+          static m() { o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_SET,
+                    error: MessageKind.NO_INSTANCE_AVAILABLE,
+                    rhs: '42')),
     const Test(
         '''
-        class C { static var o; }
+        class C {
+          static var o;
+        }
         m() { C.o(null, 42); }
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_INVOKE,
                     element: 'field(C#o)',
                     arguments: '(null,42)')),
     const Test.clazz(
         '''
         class C {
           static var o;
           m() { o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_INVOKE,
                     element: 'field(C#o)',
                     arguments: '(null,42)')),
     const Test.clazz(
         '''
         class C {
           static var o;
           m() { C.o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_INVOKE,
                     element: 'field(C#o)',
                     arguments: '(null,42)')),
+    const Test.clazz(
+        '''
+        class C {
+          var o;
+          static m() { o(null, 42); }
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_INVOKE,
+                    error: MessageKind.NO_INSTANCE_AVAILABLE,
+                    arguments: '(null,42)')),
     const Test.prefix(
         '''
         class C {
           static var o;
         }
         ''',
         'm() { p.C.o(null, 42); }',
         const Visit(VisitKind.VISIT_STATIC_FIELD_INVOKE,
                     element: 'field(C#o)',
                     arguments: '(null,42)')),
     const Test(
         '''
         class C {}
         m() => C.this(null, 42);
         ''',
         const Visit(VisitKind.ERROR_INVALID_INVOKE,
-                    error: MessageKind.THIS_PROPERTY, arguments: '(null,42)')),
+                    error: MessageKind.THIS_PROPERTY,
+                    arguments: '(null,42)')),
     // TODO(johnniwinther): Expect [VISIT_FINAL_STATIC_FIELD_SET] instead.
     const Test(
         '''
         class C { static final o = 0; }
         m() { C.o = 42; }
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_SET,
                     name: 'o',
                     rhs: '42')),
     const Test.clazz(
@@ skipping 1219 matching lines @@
                     operator: '++')),
     const Test.clazz(
         '''
         class C<T> {
           m() => T--;
         }
         ''',
         const Visit(VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_POSTFIX,
                     element: 'type_variable(C#T)',
                     operator: '--')),
-
+    const Test.clazz(
+        '''
+        class C<T> {
+          static m() => T;
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_GET,
+                    error: MessageKind.TYPE_VARIABLE_WITHIN_STATIC_MEMBER)),
+    const Test.clazz(
+        '''
+        class C<T> {
+          static m() => T(null, 42);
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_INVOKE,
+                    error: MessageKind.TYPE_VARIABLE_WITHIN_STATIC_MEMBER,
+                    arguments: '(null,42)')),
+    const Test.clazz(
+        '''
+        class C<T> {
+          static m() => T += 42;
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_COMPOUND,
+                    error: MessageKind.TYPE_VARIABLE_WITHIN_STATIC_MEMBER,
+                    operator: '+=',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C<T> {
+          static m() => ++T;
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_PREFIX,
+                    error: MessageKind.TYPE_VARIABLE_WITHIN_STATIC_MEMBER,
+                    operator: '++')),
+    const Test.clazz(
+        '''
+        class C<T> {
+          static m() => T--;
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_POSTFIX,
+                    error: MessageKind.TYPE_VARIABLE_WITHIN_STATIC_MEMBER,
+                    operator: '--')),
   ],
   'Dynamic type literals': const [
     // Dynamic type literals
     const Test(
         '''
         m() => dynamic;
         ''',
         const Visit(VisitKind.VISIT_DYNAMIC_TYPE_LITERAL_GET,
                     constant: 'dynamic')),
     // TODO(johnniwinther): Update these to expect the constant to be `dynamic`
@@ skipping 704 matching lines @@
         '''
         class C {
           static var a;
         }
         ''',
         '''
         m() => p.C.a += 42;
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_COMPOUND,
             element: 'field(C#a)', operator: '+=', rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          var o;
+          static m() { o += 42; }
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_COMPOUND,
+                    error: MessageKind.NO_INSTANCE_AVAILABLE,
+                    operator: '+=',
+                    rhs: '42')),
     const Test(
         '''
         class C {
           static get a => 0;
           static set a(_) {}
         }
         m() => C.a += 42;
         ''',
         const Visit(VisitKind.VISIT_STATIC_GETTER_SETTER_COMPOUND,
             getter: 'getter(C#a)', setter: 'setter(C#a)',
@@ skipping 495 matching lines @@
         '''
         class C {
           static var a;
         }
         ''',
         '''
         m() => --p.C.a;
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_PREFIX,
             element: 'field(C#a)', operator: '--')),
+    const Test.clazz(
+        '''
+        class C {
+          var o;
+          static m() { ++o; }
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_PREFIX,
+                    error: MessageKind.NO_INSTANCE_AVAILABLE,
+                    operator: '++')),
     const Test(
         '''
         class C {
           static get a => 0;
           static set a(_) {}
         }
         m() => ++C.a;
         ''',
         const Visit(VisitKind.VISIT_STATIC_GETTER_SETTER_PREFIX,
             getter: 'getter(C#a)', setter: 'setter(C#a)',
@@ skipping 361 matching lines @@
         '''
         class C {
           static var a;
         }
         ''',
         '''
         m() => p.C.a--;
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_POSTFIX,
             element: 'field(C#a)', operator: '--')),
+    const Test.clazz(
+        '''
+        class C {
+          var o;
+          static m() { o--; }
+        }
+        ''',
+        const Visit(VisitKind.ERROR_INVALID_POSTFIX,
+                    error: MessageKind.NO_INSTANCE_AVAILABLE,
+                    operator: '--')),
     const Test(
         '''
         class C {
           static get a => 0;
           static set a(_) {}
         }
         m() => C.a++;
         ''',
         const Visit(VisitKind.VISIT_STATIC_GETTER_SETTER_POSTFIX,
             getter: 'getter(C#a)', setter: 'setter(C#a)',
@@ skipping 673 matching lines @@
         '''
         m(a) => a ??= 42;
         ''',
         const Visit(
             VisitKind.VISIT_PARAMETER_COMPOUND,
             element: 'parameter(m#a)',
             operator: '??=',
             rhs: '42')),
   ],
 };