Fix compiler stats

Fix compiler stats

Prints the stats into a zone-allocated string that can either be dumped to the console, or displayed as a whole in the observatory.

Distinguish token consumption between class parsing and function parsing when compiling.

Change stat counter macros use thread instead of isolate.

Committed: https://github.com/dart-lang/sdk/commit/d3a2f619bba1a379c28d47132ad92ca9350f677f

[hausner, 2015-08-18 23:46:58]

hausner@google.com changed reviewers:
+ johnmccutchan@google.com

[hausner, 2015-08-18 23:47:28]

John, could you please take a look and let me know which metrics you want in the
Observatory?

[Cutch, 2015-08-20 21:35:04]

On 2015/08/18 23:47:28, hausner wrote:
> John, could you please take a look and let me know which metrics you want in
the
> Observatory?

As discussed offline:

- Every counter should be a Metric.
- You can just use the base Metric class without sub-classing.
- For now all metrics will be displayed in Observatory. We may need to improve
the UI to hide less useful counters.
- Consider starting your counter name with a "_", for example,
"_compiler.function.count" if you don't think users will care.

[hausner, 2015-08-27 18:31:00]

Making every stat counter a metric is very heavyweight. The mechanism is quite
baroque and I don't want to bury a single integer variable under a ton of macros
and accessor functions.

[hausner, 2015-09-01 17:21:29]

hausner@google.com changed reviewers:
+ iposva@google.com
- johnmccutchan@google.com

[Ivan Posva, 2015-09-04 19:22:59]

LGTMwC

-Ivan

https://codereview.chromium.org/1300033002/diff/100001/runtime/vm/compiler_st...
File runtime/vm/compiler_stats.cc (right):

https://codereview.chromium.org/1300033002/diff/100001/runtime/vm/compiler_st...
runtime/vm/compiler_stats.cc:94: static void PrintToStats(const char* format,
...) {
Please ensure that format and parameters are valid by using PRINTF_ATTRIBUTE(1,
2).
Also a comment explaining that this is used to parameterize the Log below would
be helpful.

[hausner, 2015-09-04 20:14:13]

Committed patchset #7 (id:120001) manually as
d3a2f619bba1a379c28d47132ad92ca9350f677f (presubmit successful).

[hausner, 2015-09-04 20:45:20]

Thank you.

https://codereview.chromium.org/1300033002/diff/100001/runtime/vm/compiler_st...
File runtime/vm/compiler_stats.cc (right):

https://codereview.chromium.org/1300033002/diff/100001/runtime/vm/compiler_st...
runtime/vm/compiler_stats.cc:94: static void PrintToStats(const char* format,
...) {
On 2015/09/04 19:22:59, Ivan Posva wrote:
> Please ensure that format and parameters are valid by using
PRINTF_ATTRIBUTE(1,
> 2).
> Also a comment explaining that this is used to parameterize the Log below
would
> be helpful.

Done.