Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: runtime/vm/parser.h

Issue 1300033002: Fix compiler stats (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.h
diff --git a/runtime/vm/parser.h b/runtime/vm/parser.h
index f081a7a0922a1d00e95ecd54be1f61e4a223fe7a..24ff1acdd38db5920950c8cf41cb75e1a7fcca89 100644
--- a/runtime/vm/parser.h
+++ b/runtime/vm/parser.h
@@ -211,10 +211,6 @@ class Parser : public ValueObject {
// given static field.
static ParsedFunction* ParseStaticFieldInitializer(const Field& field);
- // Returns a RawFunction or RawError.
- static RawObject* ParseFunctionFromSource(const Class& owning_class,
- const String& source);
-
// Parse a function to retrieve parameter information that is not retained in
// the dart::Function object. Returns either an error if the parse fails
// (which could be the case for local functions), or a flat array of entries
@@ -303,7 +299,6 @@ class Parser : public ValueObject {
if (token_kind_ == Token::kILLEGAL) {
ComputeCurrentToken();
}
- INC_STAT(isolate_, num_token_checks, 1);
return token_kind_;
}
@@ -323,7 +318,7 @@ class Parser : public ValueObject {
// Reset cache and advance the token.
token_kind_ = Token::kILLEGAL;
tokens_iterator_.Advance();
- INC_STAT(isolate_, num_tokens_consumed, 1);
+ INC_STAT(thread(), num_tokens_consumed, 1);
}
void ConsumeRightAngleBracket();
void CheckToken(Token::Kind token_expected, const char* msg = NULL);
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698