Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 12995008: Work around issue 9360. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Work around issue 9360. BUG=8687 Committed: https://code.google.com/p/dart/source/detail?r=20406

Patch Set 1 #

Total comments: 2

Patch Set 2 : Be compatible with Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M utils/pub/io.dart View 1 2 chunks +1 line, -3 lines 0 comments Download
M utils/pub/log.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M utils/pub/utils.dart View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
7 years, 9 months ago (2013-03-21 23:57:48 UTC) #1
Bob Nystrom
https://codereview.chromium.org/12995008/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/12995008/diff/1/utils/pub/io.dart#newcode24 utils/pub/io.dart:24: // fixed. Will this break code on Windows? I ...
7 years, 9 months ago (2013-03-22 15:06:55 UTC) #2
nweiz
I've switched to a mechanism that takes \r\n into account. I've also fixed another case ...
7 years, 9 months ago (2013-03-22 18:31:03 UTC) #3
Bob Nystrom
LGTM!
7 years, 9 months ago (2013-03-22 18:46:19 UTC) #4
nweiz
7 years, 9 months ago (2013-03-22 18:49:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698