Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: utils/pub/io.dart

Issue 12995008: Work around issue 9360. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Be compatible with Windows. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/pub/log.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index 5694abb8c1e87f3af7f5697291734930db905fce..da45a20d390e1f20c9bfce2489114dfa26e191b6 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -20,8 +20,6 @@ import 'utils.dart';
export '../../pkg/http/lib/http.dart' show ByteStream;
-final NEWLINE_PATTERN = new RegExp("\r\n?|\n\r?");
-
/// Returns whether or not [entry] is nested somewhere within [dir]. This just
/// performs a path comparison; it doesn't look at the actual filesystem.
bool isBeneath(String entry, String dir) {
@@ -410,7 +408,7 @@ Future<PubProcessResult> runProcess(String executable, List<String> args,
.then((result) {
// TODO(rnystrom): Remove this and change to returning one string.
List<String> toLines(String output) {
- var lines = output.split(NEWLINE_PATTERN);
+ var lines = splitLines(output);
if (!lines.isEmpty && lines.last == "") lines.removeLast();
return lines;
}
« no previous file with comments | « no previous file | utils/pub/log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698