Issue 1297313005: Fix the error response for bad isolate ids, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1297313005: Fix the error response for bad isolate ids, etc. (Closed)

Created:
5 years, 4 months ago by turnidge

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix the error response for bad isolate ids, etc. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/0706f6de29bc29bbeebad192d65d2ce3fe42051f

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -50 lines)			Patch
M	runtime/observatory/tests/service/get_isolate_rpc_test.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	runtime/vm/service/client.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/service/message.dart	View	1 chunk	+3 lines, -14 lines	0 comments	Download
M	runtime/vm/service/running_isolates.dart	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/service/vmservice.dart	View	4 chunks	+34 lines, -32 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

turnidge

Committed patchset #1 (id:1) manually as 0706f6de29bc29bbeebad192d65d2ce3fe42051f (presubmit successful).

5 years, 4 months ago (2015-08-20 19:58:33 UTC) #4

nweiz

5 years, 4 months ago (2015-08-20 21:43:25 UTC) #5

Message was sent while issue was closed.

On 2015/08/20 19:58:33, turnidge wrote:
> Committed patchset #1 (id:1) manually as
> 0706f6de29bc29bbeebad192d65d2ce3fe42051f (presubmit successful).

DBC: don't forget to update the changelog for 1.13!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages