Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: runtime/observatory/tests/service/get_isolate_rpc_test.dart

Issue 1297313005: Fix the error response for bad isolate ids, etc. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/service/client.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
7 import 'package:unittest/unittest.dart'; 7 import 'package:unittest/unittest.dart';
8 8
9 import 'test_helper.dart'; 9 import 'test_helper.dart';
10 10
(...skipping 11 matching lines...) Expand all
22 expect(result['pauseOnExit'], isFalse); 22 expect(result['pauseOnExit'], isFalse);
23 expect(result['pauseEvent']['type'], equals('Event')); 23 expect(result['pauseEvent']['type'], equals('Event'));
24 expect(result['error'], isNull); 24 expect(result['error'], isNull);
25 expect(result['rootLib']['type'], equals('@Library')); 25 expect(result['rootLib']['type'], equals('@Library'));
26 expect(result['libraries'].length, isPositive); 26 expect(result['libraries'].length, isPositive);
27 expect(result['libraries'][0]['type'], equals('@Library')); 27 expect(result['libraries'][0]['type'], equals('@Library'));
28 expect(result['breakpoints'].length, isZero); 28 expect(result['breakpoints'].length, isZero);
29 expect(result['_heaps']['new']['type'], equals('HeapSpace')); 29 expect(result['_heaps']['new']['type'], equals('HeapSpace'));
30 expect(result['_heaps']['old']['type'], equals('HeapSpace')); 30 expect(result['_heaps']['old']['type'], equals('HeapSpace'));
31 }, 31 },
32
33 (VM vm) async {
34 var params = {
35 'isolateId': 'badid',
36 };
37 bool caughtException;
38 try {
39 await vm.invokeRpcNoUpgrade('getIsolate', params);
40 expect(false, isTrue, reason:'Unreachable');
41 } on ServerRpcException catch(e) {
42 caughtException = true;
43 expect(e.code, equals(ServerRpcException.kInvalidParams));
44 expect(e.message,
45 "getIsolate: invalid 'isolateId' parameter: badid");
46 }
47 expect(caughtException, isTrue);
48 },
32 ]; 49 ];
33 50
34 main(args) async => runVMTests(args, tests); 51 main(args) async => runVMTests(args, tests);
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/service/client.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698