Fix most implementations of UriResolver.restoreAbsolute.

Fix most implementations of UriResolver.restoreAbsolute.

Although it wasn't previously clear in the documentation,
implementations of UriResolver.restoreAbsolute() should only depend on
Source.fullName.  To do otherwise breaks some assumptions made by
analysis server.  This CL fixes all implementations except
SdkExtUriResolver (which has been deferred to issue #24090).

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/8f2ed2c68d37916d436aff920ce5f308058570de

[Paul Berry, 2015-08-14 21:58:55]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-08-14 22:06:20]

LGTM

[Cutch, 2015-08-14 23:04:10]

On 2015/08/14 22:06:20, Brian Wilkerson wrote:
> LGTM

Hi,

Side question related to SdkExtUriResolver- I have a CL which fixes the script
entry case for SdkExtUriResolver but it can't handle parts. I noticed that the
DartUriResolver doesn't imeplement restoreUri and this CL does not implement
restoreUri for the DartUriResolver either. Is the plan to leave restoreUri
unimplemented for DartUriResolver?

[Paul Berry, 2015-08-18 18:18:49]

On 2015/08/14 23:04:10, Cutch wrote:
> On 2015/08/14 22:06:20, Brian Wilkerson wrote:
> > LGTM
> 
> Hi,
> 
> Side question related to SdkExtUriResolver- I have a CL which fixes the script
> entry case for SdkExtUriResolver but it can't handle parts. I noticed that the
> DartUriResolver doesn't imeplement restoreUri and this CL does not implement
> restoreUri for the DartUriResolver either. Is the plan to leave restoreUri
> unimplemented for DartUriResolver?

Sorry for the slow reply.  You're right, and I think it's an oversight that
DartUriResolver doesn't implement restoreAbsolute.  Fortunately it's benign,
since the two uses of restoreAbsolute in our toolchain don't wind up using it
for "dart:" URIs, but I still think it ought to be fixed to avoid confusing
future maintainers.  I'll file a bug.

[Paul Berry, 2015-08-18 18:32:19]

Committed patchset #1 (id:1) manually as
8f2ed2c68d37916d436aff920ce5f308058570de (presubmit successful).