pkg/analyzer/lib/source/sdk_ext.dart - Issue 1296653003: Fix most implementations of UriResolver.restoreAbsolute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/source/sdk_ext.dart

Issue 1296653003: Fix most implementations of UriResolver.restoreAbsolute. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/source/sdk_ext.dart

diff --git a/pkg/analyzer/lib/source/sdk_ext.dart b/pkg/analyzer/lib/source/sdk_ext.dart

index 7caad4359c4ef100b357fa9c7f2315a3a0e7a1fa..6cd358f8f17b9507cd44fcdbe076fc58943781ca 100644

--- a/pkg/analyzer/lib/source/sdk_ext.dart

+++ b/pkg/analyzer/lib/source/sdk_ext.dart

@@ -76,6 +76,8 @@ class SdkExtUriResolver extends UriResolver {

@override

Uri restoreAbsolute(Source source) {

+ // TODO(paulberry, johnmccutchan): this has incorrect semantics because it

+ // refers to source.uri. See dartbug.com/24090.

String libraryName = _libraryName(source.uri);

if (_registeredSdkExtension(libraryName)) {

return source.uri;