Issue 1296403004: dart2js cps: Do not treat final field reads as effectively constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1296403004: dart2js cps: Do not treat final field reads as effectively constant. (Closed)

Created:
5 years, 4 months ago by asgerf

Modified:
5 years, 4 months ago

Reviewers:
Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Do not treat final field reads as effectively constant. This is a workaround until assignment propagation is able to propagate constants more effectively. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/6c6ac77475966625168c0d5a59164e773d00270f

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 4 months ago (2015-08-19 08:53:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6c6ac77475966625168c0d5a59164e773d00270f (presubmit successful).