pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart - Issue 1296403004: dart2js cps: Do not treat final field reads as effectively constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1296403004: dart2js cps: Do not treat final field reads as effectively constant. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

index 65d4a5578ce44f90df38398f5ff0c60cafb0d6c7..527113a208597136b0ac7419e9ada2155477cfd1 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

@@ -711,7 +711,7 @@ class GetField extends Primitive {

accept(Visitor visitor) => visitor.visitGetField(this);

bool get isSafeForElimination => objectIsNotNull;

- bool get isSafeForReordering => objectIsNotNull && field.isFinal;

+ bool get isSafeForReordering => false;

}

/// Get the length of a string or native list.

« no previous file with comments | « no previous file | pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart » ('j') | no next file with comments »