Issue 1294423002: cps: Use BuiltinOperator.IsNumber for 'is num'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1294423002: cps: Use BuiltinOperator.IsNumber for 'is num' (Closed)

Created:
5 years, 4 months ago by sra1

Modified:
5 years, 4 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

cps: Use BuiltinOperator.IsNumber for 'is num' Use double quotes for JavaScript string in expansion of 'is num' for consistency with other strings. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/bd4b9690a209582609d88633447839534d691843

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

sra1

Is it the intention to introduce builtin operators for 'x is String', 'x is !String' ...

5 years, 4 months ago (2015-08-18 16:44:57 UTC) #2

asgerf

LGTM If it can easily be done in code generation, then code generation is fine ...

5 years, 4 months ago (2015-08-19 08:28:41 UTC) #3

sra1

5 years, 4 months ago (2015-08-19 15:21:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd4b9690a209582609d88633447839534d691843 (presubmit successful).