Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1294423002: cps: Use BuiltinOperator.IsNumber for 'is num' (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 7dced8a008409eaf6b2ed38629ec87217c35e5ff..d1d7bbad7c863d6356f87dc16d3bffe3bc75914d 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -867,13 +867,13 @@ class CodeGenerator extends tree_ir.StatementVisitor
case BuiltinOperator.IsFalsy:
return new js.Prefix('!', args[0]);
case BuiltinOperator.IsNumber:
- return js.js("typeof # === 'number'", args);
+ return js.js('typeof # === "number"', args);
case BuiltinOperator.IsNotNumber:
- return js.js("typeof # !== 'number'", args);
+ return js.js('typeof # !== "number"', args);
case BuiltinOperator.IsFloor:
- return js.js("Math.floor(#) === #", args);
+ return js.js('Math.floor(#) === #', args);
case BuiltinOperator.IsNumberAndFloor:
- return js.js("typeof # === 'number' && Math.floor(#) === #", args);
+ return js.js('typeof # === "number" && Math.floor(#) === #', args);
}
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698