Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1293383011: Add an IsolateRunnable event to the service protocol. Improve service docs. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an IsolateRunnable event to the service protocol. Improve service docs. Closes #24140 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/7e8bb130f26d5cf68c19d0dc082e99ee1ca6e282

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -26 lines) Patch
M runtime/observatory/lib/src/app/application.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 1 5 chunks +28 lines, -17 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/service/service.md View 4 chunks +16 lines, -7 lines 0 comments Download
M runtime/vm/service_event.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service_event.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 4 months ago (2015-08-20 20:44:21 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-20 21:27:12 UTC) #3
turnidge
Committed patchset #2 (id:20001) manually as 7e8bb130f26d5cf68c19d0dc082e99ee1ca6e282 (presubmit successful).
5 years, 4 months ago (2015-08-21 17:25:42 UTC) #4
nweiz
5 years, 3 months ago (2015-08-26 23:23:27 UTC) #5
Message was sent while issue was closed.
DBC: don't forget a changelog entry!

Powered by Google App Engine
This is Rietveld 408576698