Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: runtime/vm/isolate.cc

Issue 1293383011: Add an IsolateRunnable event to the service protocol. Improve service docs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/isolate_lifecycle_test.dart ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 1327ef24db29e36369f887c28b2f51cbaff245db..a2c6f662e4d3ee824a6fc9bd6287a9783efcbe5c 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1015,6 +1015,10 @@ bool Isolate::MakeRunnable() {
event->Instant("Runnable");
event->Complete();
}
+ if (Service::isolate_stream.enabled()) {
+ ServiceEvent runnableEvent(this, ServiceEvent::kIsolateRunnable);
+ Service::HandleEvent(&runnableEvent);
+ }
return true;
}
@@ -1704,7 +1708,9 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
const Library& lib =
Library::Handle(object_store()->root_library());
- jsobj.AddProperty("rootLib", lib);
+ if (!lib.IsNull()) {
+ jsobj.AddProperty("rootLib", lib);
+ }
timer_list().PrintTimersToJSONProperty(&jsobj);
{
« no previous file with comments | « runtime/observatory/tests/service/isolate_lifecycle_test.dart ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698