Issue 1292573003: Fix a memory leak in browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1292573003: Fix a memory leak in browser tests. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a memory leak in browser tests. This was caused by us sending down a different suite ID when we created a suite than when we got rid of it. There was *no* overlap between the two IDs, so no test suite iframes were ever being removed. Closes #317 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/1fdd728ce2baf8c238fcfabea7b3c2b91ee74e52

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -2 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/runner/browser/browser_manager.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 4 months ago (2015-08-13 21:38:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1fdd728ce2baf8c238fcfabea7b3c2b91ee74e52 (presubmit successful).