Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: lib/src/runner/browser/browser_manager.dart

Issue 1292573003: Fix a memory leak in browser tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.runner.browser.browser_manager; 5 library test.runner.browser.browser_manager;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:convert'; 8 import 'dart:convert';
9 9
10 import 'package:async/async.dart'; 10 import 'package:async/async.dart';
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 _channel.sink.add({ 187 _channel.sink.add({
188 "command": "closeSuite", 188 "command": "closeSuite",
189 "id": suiteId 189 "id": suiteId
190 }); 190 });
191 } 191 }
192 192
193 var response = await _pool.withResource(() { 193 var response = await _pool.withResource(() {
194 _channel.sink.add({ 194 _channel.sink.add({
195 "command": "loadSuite", 195 "command": "loadSuite",
196 "url": url.toString(), 196 "url": url.toString(),
197 "id": _suiteId++, 197 "id": suiteId,
198 "channel": suiteVirtualChannel.id 198 "channel": suiteVirtualChannel.id
199 }); 199 });
200 200
201 // Create a nested MultiChannel because the iframe will be using a channel 201 // Create a nested MultiChannel because the iframe will be using a channel
202 // wrapped within the host's channel. 202 // wrapped within the host's channel.
203 suiteChannel = new MultiChannel( 203 suiteChannel = new MultiChannel(
204 suiteVirtualChannel.stream, suiteVirtualChannel.sink); 204 suiteVirtualChannel.stream, suiteVirtualChannel.sink);
205 205
206 var completer = new Completer(); 206 var completer = new Completer();
207 suiteChannel.stream.listen((response) { 207 suiteChannel.stream.listen((response) {
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 291
292 final Uri observatoryUrl; 292 final Uri observatoryUrl;
293 293
294 final Uri remoteDebuggerUrl; 294 final Uri remoteDebuggerUrl;
295 295
296 _BrowserEnvironment(this._manager, this.observatoryUrl, 296 _BrowserEnvironment(this._manager, this.observatoryUrl,
297 this.remoteDebuggerUrl); 297 this.remoteDebuggerUrl);
298 298
299 CancelableFuture displayPause() => _manager._displayPause(); 299 CancelableFuture displayPause() => _manager._displayPause();
300 } 300 }
OLDNEW
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698