Issue 1292003005: Don't crash for pre-1.12 global packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1292003005: Don't crash for pre-1.12 global packages. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't crash for pre-1.12 global packages. We were assuming that all globally-activated packages have a .packages file, but this isn't true for packages that were activated by earlier versions of pub. Closes #1316 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/d90268693d1a9dbe5ea11cd9c80b842e3bf1581c

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -2 lines)			Patch
M	lib/src/executable.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	lib/src/global_packages.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	test/global/run/runs_script_without_packages_file_test.dart	View	1 chunk	+55 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 4 months ago (2015-08-18 21:25:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d90268693d1a9dbe5ea11cd9c80b842e3bf1581c (presubmit successful).