Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: lib/src/global_packages.dart

Issue 1292003005: Don't crash for pre-1.12 global packages. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/executable.dart ('k') | test/global/run/runs_script_without_packages_file_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/global_packages.dart
diff --git a/lib/src/global_packages.dart b/lib/src/global_packages.dart
index ec0f5414def719698cf03de8e0b9e225a4f52308..c58ed54c63749028f79ee2b2a24d59a97e9ae064 100644
--- a/lib/src/global_packages.dart
+++ b/lib/src/global_packages.dart
@@ -353,7 +353,6 @@ class GlobalPackages {
var snapshotPath = p.join(binDir, '$executable.dart.snapshot');
return exe.runSnapshot(snapshotPath, args,
checked: checked,
- packagesFile: _getPackagesFilePath(package),
recompile: () async {
log.fine("$package:$executable is out of date and needs to be "
"recompiled.");
« no previous file with comments | « lib/src/executable.dart ('k') | test/global/run/runs_script_without_packages_file_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698