Enable concurrent optimization test after migrating scopes to Thread*

Enable concurrent optimization test after migrating scopes to Thread*

Also move static call target table allocation into old space.

Note that stats are not thread-safe, so running two compilers concurrently may lead to inaccurate stats.

BUG=https://github.com/dart-lang/sdk/issues/24109

Committed: https://github.com/dart-lang/sdk/commit/00ef26050340f29cb67d69ad4e3ace3278302be4

[koda, 2015-08-19 17:54:56]

koda@google.com changed reviewers:
+ srdjan@google.com

[koda, 2015-08-19 18:02:31]

The test is passing with this CL, which is great.

However, the function we are optimizing is very trivial, and there are probably
code paths we're not covering.

To get coverage, when safepoint support is solid, we could add a flag to the VM
that always runs the optimizing compiler on a separate thread (with everything
else paused), and (re)run select tests under that flag.

[srdjan, 2015-08-19 18:29:34]

LGTMwC

https://codereview.chromium.org/1291803009/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1291803009/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:178: GrowableObjectArray::New(Heap::kOld))),
This is a temporary fix. Please add: TODO(srdjan): allocate in zone instead of
old-space.

[koda, 2015-08-19 18:44:28]

https://codereview.chromium.org/1291803009/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1291803009/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:178: GrowableObjectArray::New(Heap::kOld))),
On 2015/08/19 18:29:34, srdjan wrote:
> This is a temporary fix. Please add: TODO(srdjan): allocate in zone instead of
> old-space.

OK, although it doesn't look temporary to me. It's converted to an Array (using
MakeArray) and seems to be unconditionally stored in the Code object in
FinalizeStaticCallTargetsTable. (I suppose if it's usually empty, it's wasteful
to always allocate, and we could leave the field 'null', provided the rest of
the code can handle that.)

[srdjan, 2015-08-19 19:46:50]

https://codereview.chromium.org/1291803009/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1291803009/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:178: GrowableObjectArray::New(Heap::kOld))),
On 2015/08/19 18:44:28, koda wrote:
> On 2015/08/19 18:29:34, srdjan wrote:
> > This is a temporary fix. Please add: TODO(srdjan): allocate in zone instead
of
> > old-space.
> 
> OK, although it doesn't look temporary to me. It's converted to an Array
(using
> MakeArray) and seems to be unconditionally stored in the Code object in
> FinalizeStaticCallTargetsTable. (I suppose if it's usually empty, it's
wasteful
> to always allocate, and we could leave the field 'null', provided the rest of
> the code can handle that.)
> 

There is still 'garbage' created by the GrowableObjectArray descriptor and by
the Grow operation.

[koda, 2015-08-19 22:16:51]

Committed patchset #4 (id:60001) manually as
00ef26050340f29cb67d69ad4e3ace3278302be4 (presubmit successful).