Enable concurrent optimization test after migrating scopes to Thread*

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
@@ skipping 157 matching lines @@
         parsed_function_(parsed_function),
         flow_graph_(*flow_graph),
         block_order_(*flow_graph->CodegenBlockOrder(is_optimizing)),
         current_block_(NULL),
         exception_handlers_list_(NULL),
         pc_descriptors_list_(NULL),
         stackmap_table_builder_(NULL),
         block_info_(block_order_.length()),
         deopt_infos_(),
         static_calls_target_table_(GrowableObjectArray::ZoneHandle(
-            GrowableObjectArray::New())),
+            GrowableObjectArray::New(Heap::kOld))),

[srdjan, 2015/08/19 18:29:34]

This is a temporary fix. Please add: TODO(srdjan): allocate in zone instead of
old-space.

[koda, 2015/08/19 18:44:28]

OK, although it doesn't look temporary to me. It's converted to an Array (using
MakeArray) and seems to be unconditionally stored in the Code object in
FinalizeStaticCallTargetsTable. (I suppose if it's usually empty, it's wasteful
to always allocate, and we could leave the field 'null', provided the rest of
the code can handle that.)

[srdjan, 2015/08/19 19:46:50]

There is still 'garbage' created by the GrowableObjectArray descriptor and by
the Grow operation.

         is_optimizing_(is_optimizing),
         may_reoptimize_(false),
         intrinsic_mode_(false),
         double_class_(Class::ZoneHandle(
             isolate_->object_store()->double_class())),
         mint_class_(Class::ZoneHandle(
             isolate_->object_store()->mint_class())),
         float32x4_class_(Class::ZoneHandle(
             isolate_->object_store()->float32x4_class())),
         float64x2_class_(Class::ZoneHandle(
@@ skipping 320 matching lines @@
     ASSERT(is_optimizing() || FrameStateIsSafeToCall());
 #endif
   }
 
   if (inline_id_to_function_.length() > max_inlining_id + 1) {
     // TODO(srdjan): Some inlined function can disappear,
     // truncate 'inline_id_to_function_'.
   }
 
   if (is_optimizing()) {
-    LogBlock lb(Isolate::Current());
+    LogBlock lb(Thread::Current());
     intervals.Add(IntervalStruct(prev_offset, prev_inlining_id));
     inlined_code_intervals_ =
         Array::New(intervals.length() * Code::kInlIntNumEntries, Heap::kOld);
     Smi& start_h = Smi::Handle();
     Smi& caller_inline_id = Smi::Handle();
     Smi& inline_id = Smi::Handle();
     for (intptr_t i = 0; i < intervals.length(); i++) {
       if (FLAG_trace_inlining_intervals && is_optimizing()) {
         const Function& function =
             *inline_id_to_function_.At(intervals[i].inlining_id);
@@ skipping 1288 matching lines @@
 
 
 void FlowGraphCompiler::FrameStateClear() {
   ASSERT(!is_optimizing());
   frame_state_.TruncateTo(0);
 }
 #endif
 
 
 }  // namespace dart