Issue 1291323004: dart2js: Use 'new Array' instead of 'Array' in the JS output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1291323004: dart2js: Use 'new Array' instead of 'Array' in the JS output. (Closed)

Created:
5 years, 4 months ago by Kevin Millikin (Google)

Modified:
5 years, 3 months ago

Reviewers:
asgerf, floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Use 'new Array' instead of 'Array' in the JS output. Though the spec says that they are equivalent when called, they are not optimized equivalently by V8. This might be considered a performance bug in V8 (https://code.google.com/p/v8/issues/detail?id=4380) but we should use the much faster one unless that issue is fixed. BUG= R=asgerf@google.com, floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/aa9e569ecf2d561a26dec69a0fe2af772896f228

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/compiler/lib/src/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

Kevin Millikin (Google)

Committed patchset #2 (id:20001) manually as aa9e569ecf2d561a26dec69a0fe2af772896f228 (presubmit successful).

5 years, 4 months ago (2015-08-20 09:03:48 UTC) #5

floitsch

5 years, 3 months ago (2015-09-10 16:39:22 UTC) #6

Message was sent while issue was closed.

The V8 bug was fixed today/yesterday.
We should file a bug for 1.14 to revert this CL.