pkg/compiler/lib/src/ssa/builder.dart - Issue 1291323004: dart2js: Use 'new Array' instead of 'Array' in the JS output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1291323004: dart2js: Use 'new Array' instead of 'Array' in the JS output. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Merge in tip of tree. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index 6021ffcbecdb4207af86a1ec257d66a322da61fe..080ed0254da9ae88b4919e5579522507ecb1cba5 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -5012,7 +5012,7 @@ class SsaBuilder extends ast.Visitor

add(conversion);

inputs[0] = conversion;

}

- js.Template code = js.js.parseForeignJS('Array(#)');

+ js.Template code = js.js.parseForeignJS('new Array(#)');

var behavior = new native.NativeBehavior();

behavior.typesReturned.add(expectedType);

// The allocation can throw only if the given length is a double

« no previous file with comments | « no previous file | no next file » | no next file with comments »