Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290893006: - Clarify the order of setting the interrupt bit and posting a message in (Closed)

Created:
5 years, 4 months ago by Ivan Posva
Modified:
5 years, 4 months ago
Reviewers:
zra, koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Clarify the order of setting the interrupt bit and posting a message in Dart_InterruptIsolate. BUG= Committed: https://github.com/dart-lang/sdk/commit/3ff350ed095c0b0d5c3225228c601a86bfa27cd0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/vm/code_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ivan Posva
5 years, 4 months ago (2015-08-18 23:28:29 UTC) #2
koda
https://codereview.chromium.org/1290893006/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1290893006/diff/1/runtime/vm/dart_api_impl.cc#newcode1607 runtime/vm/dart_api_impl.cc:1607: // If the isolate is blocked on the message ...
5 years, 4 months ago (2015-08-19 00:29:46 UTC) #4
Ivan Posva
https://codereview.chromium.org/1290893006/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1290893006/diff/1/runtime/vm/dart_api_impl.cc#newcode1607 runtime/vm/dart_api_impl.cc:1607: // If the isolate is blocked on the message ...
5 years, 4 months ago (2015-08-19 08:29:17 UTC) #5
Ivan Posva
5 years, 4 months ago (2015-08-21 02:26:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3ff350ed095c0b0d5c3225228c601a86bfa27cd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698