Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: runtime/vm/code_generator.cc

Issue 1290893006: - Clarify the order of setting the interrupt bit and posting a message in (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Review comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_generator.h" 5 #include "vm/code_generator.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast.h" 8 #include "vm/ast.h"
9 #include "vm/code_patcher.h" 9 #include "vm/code_patcher.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 1359 matching lines...) Expand 10 before | Expand all | Expand 10 after
1370 const UnwindError& error = UnwindError::Handle(UnwindError::New(msg)); 1370 const UnwindError& error = UnwindError::Handle(UnwindError::New(msg));
1371 Exceptions::PropagateError(error); 1371 Exceptions::PropagateError(error);
1372 UNREACHABLE(); 1372 UNREACHABLE();
1373 } 1373 }
1374 } 1374 }
1375 if ((interrupt_bits & Isolate::kApiInterrupt) != 0) { 1375 if ((interrupt_bits & Isolate::kApiInterrupt) != 0) {
1376 // Signal isolate interrupt event. 1376 // Signal isolate interrupt event.
1377 Debugger::SignalIsolateInterrupted(); 1377 Debugger::SignalIsolateInterrupted();
1378 1378
1379 Dart_IsolateInterruptCallback callback = isolate->InterruptCallback(); 1379 Dart_IsolateInterruptCallback callback = isolate->InterruptCallback();
1380 if (callback) { 1380 if (callback != NULL) {
1381 if ((*callback)()) { 1381 if ((*callback)()) {
1382 return; 1382 return;
1383 } else { 1383 } else {
1384 // TODO(turnidge): Unwind the stack. 1384 // TODO(turnidge): Unwind the stack.
1385 UNIMPLEMENTED(); 1385 UNIMPLEMENTED();
1386 } 1386 }
1387 } 1387 }
1388 } 1388 }
1389 1389
1390 if ((stack_overflow_flags & Isolate::kOsrRequest) != 0) { 1390 if ((stack_overflow_flags & Isolate::kOsrRequest) != 0) {
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
1848 const intptr_t elm_size = old_data.ElementSizeInBytes(); 1848 const intptr_t elm_size = old_data.ElementSizeInBytes();
1849 const TypedData& new_data = 1849 const TypedData& new_data =
1850 TypedData::Handle(TypedData::New(cid, new_size, Heap::kOld)); 1850 TypedData::Handle(TypedData::New(cid, new_size, Heap::kOld));
1851 TypedData::Copy(new_data, 0, old_data, 0, old_size * elm_size); 1851 TypedData::Copy(new_data, 0, old_data, 0, old_size * elm_size);
1852 typed_data_cell.SetAt(0, new_data); 1852 typed_data_cell.SetAt(0, new_data);
1853 arguments.SetReturn(new_data); 1853 arguments.SetReturn(new_data);
1854 } 1854 }
1855 1855
1856 1856
1857 } // namespace dart 1857 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698