Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1290763003: Drop support for old SDK and shelf versions. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop support for old SDK and shelf versions. This allows us to get rid of a lot of old hacks. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/a635337bce85dd49ed74a24eeb6dc9c8ed7652ed

Patch Set 1 #

Patch Set 2 : Fix analysis hints #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -198 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M README.md View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/runner/browser/iframe_listener.dart View 3 chunks +5 lines, -10 lines 0 comments Download
M lib/src/runner/browser/server.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/src/runner/configuration.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/runner/loader.dart View 1 chunk +18 lines, -22 lines 0 comments Download
M lib/src/util/dart.dart View 2 chunks +7 lines, -37 lines 0 comments Download
M lib/src/util/io.dart View 2 chunks +1 line, -26 lines 0 comments Download
D lib/src/util/isolate_wrapper.dart View 1 chunk +0 lines, -48 lines 0 comments Download
M lib/src/util/one_off_handler.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M lib/src/util/path_handler.dart View 1 3 chunks +2 lines, -4 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M pubspec.yaml View 2 chunks +3 lines, -3 lines 0 comments Download
M test/io.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 4 months ago (2015-08-12 21:10:58 UTC) #1
kevmoo
LGTM while you're at it, update usages of Platform.executable in test/io.dart in _pubPath in runDart ...
5 years, 4 months ago (2015-08-12 22:14:05 UTC) #2
nweiz
Code review changes
5 years, 4 months ago (2015-08-13 18:10:43 UTC) #3
nweiz
https://codereview.chromium.org/1290763003/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1290763003/diff/20001/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Narrow the constraints on the Dart SDK and ...
5 years, 4 months ago (2015-08-13 18:11:11 UTC) #4
nweiz
5 years, 4 months ago (2015-08-13 18:11:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a635337bce85dd49ed74a24eeb6dc9c8ed7652ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698