Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: lib/src/runner/browser/iframe_listener.dart

Issue 1290763003: Drop support for old SDK and shelf versions. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « README.md ('k') | lib/src/runner/browser/server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/iframe_listener.dart
diff --git a/lib/src/runner/browser/iframe_listener.dart b/lib/src/runner/browser/iframe_listener.dart
index e8bc3065931bb8170d0842046beefe61006ccd2e..9da65771bfd5f7e96f57cf460e821a6db4112af9 100644
--- a/lib/src/runner/browser/iframe_listener.dart
+++ b/lib/src/runner/browser/iframe_listener.dart
@@ -43,18 +43,15 @@ class IframeListener {
main = getMain();
} on NoSuchMethodError catch (_) {
_sendLoadException(channel, "No top-level main() function defined.");
- // TODO(nweiz): Just "return;" when issue 23200 is fixed.
- return null;
+ return;
}
if (main is! Function) {
_sendLoadException(channel, "Top-level main getter is not a function.");
- // TODO(nweiz): Just "return;" when issue 23200 is fixed.
- return null;
+ return;
} else if (main is! AsyncFunction) {
_sendLoadException(channel, "Top-level main() function takes arguments.");
- // TODO(nweiz): Just "return;" when issue 23200 is fixed.
- return null;
+ return;
}
var declarer;
@@ -70,8 +67,7 @@ class IframeListener {
"type": "error",
"error": RemoteException.serialize(error, stackTrace)
});
- // TODO(nweiz): Just "return;" when issue 23200 is fixed.
- return null;
+ return;
}
var url = Uri.parse(window.location.href);
@@ -83,8 +79,7 @@ class IframeListener {
declarer.tests, platform: browser, metadata: metadata);
new IframeListener._(suite)._listen(channel);
- // TODO(nweiz): Remove this when issue 23200 is fixed.
- return null;
+ return;
}
/// Constructs a [MultiChannel] wrapping the `postMessage` communication with
« no previous file with comments | « README.md ('k') | lib/src/runner/browser/server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698