Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1287513002: Disable flaky test under Windows (and fix formatting from an easlier CL) (Closed)

Created:
5 years, 4 months ago by Brian Wilkerson
Modified:
5 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable flaky test under Windows (and fix formatting from an earlier CL) R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/6359735d93df113637c7a98157be29b4ecca89b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +10 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/java_io_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
Dan suggested that we 'print' information for the Windows bots so we could see whether ...
5 years, 4 months ago (2015-08-10 20:26:28 UTC) #2
Paul Berry
Nit: s/easlier/earlier/ in the commit message Otherwise lgtm :)
5 years, 4 months ago (2015-08-10 20:28:55 UTC) #3
Brian Wilkerson
5 years, 4 months ago (2015-08-10 20:32:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6359735d93df113637c7a98157be29b4ecca89b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698