Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Side by Side Diff: pkg/analyzer/test/file_system/physical_resource_provider_test.dart

Issue 1287513002: Disable flaky test under Windows (and fix formatting from an easlier CL) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/java_io_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.physical_file_system; 5 library test.physical_file_system;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:core' hide Resource; 8 import 'dart:core' hide Resource;
9 import 'dart:io' as io; 9 import 'dart:io' as io;
10 10
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 290
291 test_watchFile_delete() { 291 test_watchFile_delete() {
292 var path = join(tempPath, 'foo'); 292 var path = join(tempPath, 'foo');
293 var file = new io.File(path); 293 var file = new io.File(path);
294 file.writeAsStringSync('contents 1'); 294 file.writeAsStringSync('contents 1');
295 return _watchingFile(path, (changesReceived) { 295 return _watchingFile(path, (changesReceived) {
296 expect(changesReceived, hasLength(0)); 296 expect(changesReceived, hasLength(0));
297 file.deleteSync(); 297 file.deleteSync();
298 return _delayed(() { 298 return _delayed(() {
299 expect(changesReceived, hasLength(1)); 299 expect(changesReceived, hasLength(1));
300 expect(changesReceived[0].type, equals(ChangeType.REMOVE)); 300 if (io.Platform.isWindows) {
301 // See https://github.com/dart-lang/sdk/issues/23762
302 // Not sure why this breaks under Windows, but testing to see whether
303 // we are running Windows causes the type to change. For now we print
304 // the type out of curriosity.
305 print(
306 'PhysicalResourceProviderTest:test_watchFile_delete received an ev ent with type = ${changesReceived[0].type}');
307 } else {
308 expect(changesReceived[0].type, equals(ChangeType.REMOVE));
309 }
301 expect(changesReceived[0].path, equals(path)); 310 expect(changesReceived[0].path, equals(path));
302 }); 311 });
303 }); 312 });
304 } 313 }
305 314
306 test_watchFile_modify() { 315 test_watchFile_modify() {
307 var path = join(tempPath, 'foo'); 316 var path = join(tempPath, 'foo');
308 var file = new io.File(path); 317 var file = new io.File(path);
309 file.writeAsStringSync('contents 1'); 318 file.writeAsStringSync('contents 1');
310 return _watchingFile(path, (changesReceived) { 319 return _watchingFile(path, (changesReceived) {
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 443
435 setUp() { 444 setUp() {
436 tempDirectory = io.Directory.systemTemp.createTempSync('test_resource'); 445 tempDirectory = io.Directory.systemTemp.createTempSync('test_resource');
437 tempPath = tempDirectory.absolute.path; 446 tempPath = tempDirectory.absolute.path;
438 } 447 }
439 448
440 tearDown() { 449 tearDown() {
441 tempDirectory.deleteSync(recursive: true); 450 tempDirectory.deleteSync(recursive: true);
442 } 451 }
443 } 452 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/java_io_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698