Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1286193003: dart2js cps: Type a list literal as extendable, not just mutable. (Closed)

Created:
5 years, 4 months ago by asgerf
Modified:
5 years, 4 months ago
Reviewers:
karlklose, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Type a list literal as extendable, not just mutable. This would prevent rewriting into .push and .pop. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/75b6bd1e0fc9e3b8e8b1753b94c934c545a1fa8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
5 years, 4 months ago (2015-08-12 15:41:53 UTC) #2
sra1
lgtm
5 years, 4 months ago (2015-08-12 17:42:05 UTC) #4
asgerf
5 years, 4 months ago (2015-08-13 08:48:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75b6bd1e0fc9e3b8e8b1753b94c934c545a1fa8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698