Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1286193003: dart2js cps: Type a list literal as extendable, not just mutable. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index 4e8d40d03a345ae14eb4343b771037e216a70316..b090dec0a778c4934b1a6e071fead1c1f8f452ec 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -43,7 +43,7 @@ class TypeMaskSystem {
TypeMask get listType => inferrer.listType;
TypeMask get mapType => inferrer.mapType;
TypeMask get nonNullType => inferrer.nonNullType;
- TypeMask get mutableNativeListType => backend.mutableArrayType;
+ TypeMask get extendableNativeListType => backend.extendableArrayType;
TypeMask numStringBoolType;
@@ -2260,7 +2260,7 @@ class TypePropagationVisitor implements Visitor {
void visitLiteralList(LiteralList node) {
// Constant lists are translated into (Constant ListConstant(...)) IR nodes,
// and thus LiteralList nodes are NonConst.
- setValue(node, nonConstant(typeSystem.mutableNativeListType));
+ setValue(node, nonConstant(typeSystem.extendableNativeListType));
}
void visitLiteralMap(LiteralMap node) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698