Issue 1286163002: Make uncaught errors terminating isolates only get printed if nobody is listening.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1286163002: Make uncaught errors terminating isolates only get printed if nobody is listening. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make uncaught errors terminating isolates only get printed if nobody is listening. If an isolate has an error port attached, then the uncaught error is not printed when it causes the isolate to terminate. Fixes issue 24052 BUG= https://github.com/dart-lang/sdk/issues/24052 Committed: https://github.com/dart-lang/sdk/commit/43f6230376803b859c51ef54c87537dd92ed8f5a

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	runtime/vm/isolate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/isolate.cc	View		3 chunks	+11 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

LGTMwC -Ivan https://codereview.chromium.org/1286163002/diff/1/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/1286163002/diff/1/runtime/vm/isolate.cc#newcode578 runtime/vm/isolate.cc:578: I->object_store()->set_sticky_error(error); If we have notified the listener, ...

5 years, 4 months ago (2015-08-14 05:18:30 UTC) #3

Lasse Reichstein Nielsen

5 years, 4 months ago (2015-08-14 10:48:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
43f6230376803b859c51ef54c87537dd92ed8f5a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages