runtime/vm/isolate.h - Issue 1286163002: Make uncaught errors terminating isolates only get printed if nobody is listening.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.h

Issue 1286163002: Make uncaught errors terminating isolates only get printed if nobody is listening. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.h

diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h

index a21554e6c5f54f445d1227eeef67009349d27193..4f75d3f0dfcc0548e33a7a447c0292b0b02fdf44 100644

--- a/runtime/vm/isolate.h

+++ b/runtime/vm/isolate.h

@@ -477,7 +477,7 @@ class Isolate : public BaseIsolate {

void AddErrorListener(const SendPort& listener);

void RemoveErrorListener(const SendPort& listener);

- void NotifyErrorListeners(const String& msg, const String& stacktrace);

+ bool NotifyErrorListeners(const String& msg, const String& stacktrace);

bool ErrorsFatal() const { return errors_fatal_; }

void SetErrorsFatal(bool val) { errors_fatal_ = val; }

« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | runtime/vm/isolate.cc » ('J')