Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1285643004: Allow stepping when paused at isolate start. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow stepping when paused at isolate start. Fix tests. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/256b044857a44977ba1b4ca58d3d96ab39765bdf

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -75 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 4 chunks +14 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 1 3 chunks +27 lines, -31 lines 0 comments Download
A runtime/observatory/tests/service/pause_on_start_and_exit_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 5 chunks +30 lines, -36 lines 0 comments Download
M runtime/vm/debugger.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 4 months ago (2015-08-10 21:14:26 UTC) #2
turnidge
Re-doing this change with the unit tests problems fixed up.
5 years, 4 months ago (2015-08-10 21:17:55 UTC) #3
Cutch
lgtm
5 years, 4 months ago (2015-08-10 21:22:07 UTC) #4
turnidge
5 years, 4 months ago (2015-08-10 21:26:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
256b044857a44977ba1b4ca58d3d96ab39765bdf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698